Skip to content

fix: various DPT plot fixes #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2025
Merged

fix: various DPT plot fixes #3864

merged 5 commits into from
Nov 3, 2025

Conversation

@flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 31, 2025

@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.23%. Comparing base (41f80ba) to head (56f7506).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/plotting/_tools/__init__.py 66.66% 1 Missing ⚠️
src/scanpy/plotting/_utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3864      +/-   ##
==========================================
+ Coverage   76.70%   77.23%   +0.53%     
==========================================
  Files         115      115              
  Lines       12389    12393       +4     
==========================================
+ Hits         9503     9572      +69     
+ Misses       2886     2821      -65
Files with missing lines Coverage Δ
src/scanpy/tools/_dpt.py 65.69% <100.00%> (+7.17%) ⬆️
src/scanpy/plotting/_tools/__init__.py 76.76% <66.66%> (+0.87%) ⬆️
src/scanpy/plotting/_utils.py 67.01% <88.88%> (+6.42%) ⬆️

@flying-sheep flying-sheep added this to the 1.11.6 milestone Oct 31, 2025
@flying-sheep flying-sheep changed the title Fix dpt_groups_pseudotime fix: various DPT plot fixes Oct 31, 2025
ilan-gold
ilan-gold reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@ilan-gold ilan-gold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we testing whatever could have triggered the need for islice(cycle(...? It seems like we could add a test for that, at least that things dont crash. No? I guess it's tied to X.shape but just want to be sure we are checking the overflow case i.e., X.shape forcing the cycle to be used

@flying-sheep
Copy link
Member Author

flying-sheep commented Nov 1, 2025

Whenever the number of subsets is larger than the palette, the old code would crash with an IndexError. (Using zip without strict=True would cause the iteration to end after the shortest iterable runs out)

@flying-sheep
Copy link
Member Author

flying-sheep commented Nov 1, 2025

test failures are #3865

ilan-gold
ilan-gold approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Just wanted to be sure

@flying-sheep flying-sheep enabled auto-merge (squash) November 3, 2025 12:25
@flying-sheep flying-sheep merged commit 2b3e605 into main Nov 3, 2025
14 checks passed
@flying-sheep flying-sheep deleted the fix-dpt_groups_pseudotime branch November 3, 2025 12:39
flying-sheep added a commit that referenced this pull request Nov 3, 2025
@flying-sheep
Backport PR #3864: fix: various DPT plot fixes
3d1623f
@flying-sheep flying-sheep mentioned this pull request Nov 3, 2025
Merged
@scverse scverse deleted a comment from lumberbot-app bot Nov 3, 2025
flying-sheep added a commit that referenced this pull request Nov 3, 2025
@flying-sheep
Backport PR #3864 on branch 1.11.x (fix: various DPT plot fixes) (#3869)
3c2f5ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilan-gold ilan-gold ilan-gold approved these changes

@eroell eroell Awaiting requested review from eroell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.6

Development

Successfully merging this pull request may close these issues.

unexpected error in sc.pl.dpt_timeseries and dpt_groups_pseudotime

3 participants

@flying-sheep @ilan-gold